Add Utxo::new_v1_p2tr #4365
Add Utxo::new_v1_p2tr #4365
Conversation
|
👋 I see @wpaulino was un-assigned. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4365 +/- ##
==========================================
+ Coverage 85.98% 86.01% +0.02%
==========================================
Files 156 156
Lines 102605 102712 +107
Branches 102605 102712 +107
==========================================
+ Hits 88229 88349 +120
+ Misses 11867 11856 -11
+ Partials 2509 2507 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🔔 1st Reminder Hey @wpaulino! This PR has been waiting for your review. |
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
Thanks! one doc nit otherwise LGTM
| } | ||
| } | ||
|
|
||
| /// Returns a `Utxo` with the `satisfaction_weight` estimate for a SegWit v1 P2TR output. |
There was a problem hiding this comment.
Should this specify that we mean a keypath spend specifically?
There was a problem hiding this comment.
Ah yes, adjusted the comment.
wvanlint
force-pushed
the
wvanlint/new_v1_p2tr
branch
from
404ead6 to
1f6095b
Compare
3 participants
This PR adds a method to create a
Utxofor a SegWit v1 P2TR output, resolving a TODO inldk-sample: https://github.com/lightningdevkit/ldk-sample/blob/6c300c7b744eddf8e3c5a3336f7c19110b9dab4e/src/bitcoind_client.rs#L431.